Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/content/__tests__/loadArtistReleaseEditorial.test.ts`:
- Around line 23-29: Combine the redundant tests in
loadArtistReleaseEditorial.test.ts by loading the template once via
loadTemplate("artist-release-editorial") and asserting both that
template.styleGuide exists and that styleGuide.customInstruction is a non-empty
string (e.g., typeof === "string" and length > 0 or matches a specific pattern);
update the test named "has a customInstruction in the style guide" to perform
both checks against template.styleGuide.customInstruction instead of re-loading
the template in a separate test.
- Around line 10-21: Replace the ad-hoc assertions in the "loads the
artist-release-editorial template" test with a Zod validation: import or define
the appropriate Zod schema (e.g., TemplateSchema or artistReleaseTemplateSchema)
and run schema.parse or schema.safeParse on the object returned by
loadTemplate("artist-release-editorial"); assert that validation succeeds (or
that safeParse().success is true) and optionally assert specific fields from the
parsed/typed result (e.g., parsed.template.name, parsed.template.imagePrompt,
parsed.template.usesFaceGuide, parsed.template.styleGuide,
parsed.template.captionGuide, parsed.template.videoMoods,
parsed.template.videoMovements, parsed.template.captionExamples) instead of
manual truthiness/length checks so the test enforces the full shape via Zod.

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/content/templates/artist-release-editorial/video-moods.json">

<violation number="1" location="src/content/templates/artist-release-editorial/video-moods.json:8">
P3: Typo: `its` → `it's`. This is the contraction of "it is," not the possessive.</violation>
</file>

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/content/templates/artist-release-editorial/style-guide.json">

<violation number="1" location="src/content/templates/artist-release-editorial/style-guide.json:5">
P2: The `customInstruction` tells the model to "match the layout and composition style shown in the reference images", but no reference images exist in the template yet. This will produce a misleading/broken prompt at runtime. Consider removing or rewording the reference-image clause until the images are actually added, or gate usage of this template on their presence.</violation>
</file>

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/content/generateContentImage.ts`:
- Around line 51-53: Deduplicate additionalImageUrls before appending to
imageUrls: filter additionalImageUrls (the variable used in
generateContentImage.ts) to remove duplicates and any URLs already present in
imageUrls (and any faceGuideUrl/reference entries that are pushed earlier), then
push the unique ones; use a Set or equivalent to ensure both intra-additional
duplicates and cross-list duplicates are removed before calling
imageUrls.push(...additionalImageUrls).

---

Nitpick comments:
In `@src/content/__tests__/generateContentImage.test.ts`:
- Around line 55-99: Add a regression test to generateContentImage that covers
overlapping URLs: mock fs.readFile and fal.storage.upload as in other tests,
call generateContentImage with faceGuideUrl and referenceImagePath (or mocked
uploaded ref URL) and include those same URLs inside additionalImageUrls, then
assert via mockFalSubscribe (mockFalSubscribe.mock.calls[0][1]) that
callArgs.image_urls contains a deduplicated list (unique URLs only, preserving
the expected order) so duplicates from additionalImageUrls are not repeated;
reference generateContentImage, mockFalSubscribe, fal.storage.upload, and
fs.readFile to locate where to add the test.

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/tasks/createContentTask.ts">

<violation number="1" location="src/tasks/createContentTask.ts:103">
P2: The first image in `payload.images` is already used as the face guide by `resolveFaceGuide`. Passing the full array here duplicates it in the `image_urls` sent to the model. Slice off the first element to avoid the duplicate.</violation>
</file>

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/content/__tests__/resolveFaceGuide.test.ts">

<violation number="1" location="src/content/__tests__/resolveFaceGuide.test.ts:143">
P2: The second `mockResolvedValueOnce(true)` for `detectFace` is never consumed — `detectFace` is only called once here because the implementation skips face detection once `faceGuideUrl` is already set. Consider removing the unused mock and adding an assertion like `expect(detectFace).toHaveBeenCalledTimes(1)` to explicitly verify this behavior.</violation>
</file>

<file name="src/content/detectFace.ts">

<violation number="1" location="src/content/detectFace.ts:24">
P2: The caught error is discarded — log it so failures are diagnosable. Without the error, a rate-limit, auth failure, or schema change all look identical in production logs.</violation>
</file>

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/content/detectFace.ts`:
- Around line 18-21: The code in detectFace.ts currently does a fragile cast of
result.data to Record<string, unknown> and then to unknown[] for faces
(variables: data, faces, hasFace), which can silently hide API contract changes;
replace this with explicit runtime validation using a Zod schema (e.g., define a
schema that expects an object with an optional faces array of objects) and
parse/validate result.data before using it, then set hasFace based on the
validated output (or throw/log a clear error when validation fails) so
unexpected shapes are surfaced early.
- Around line 24-29: The catch block in detectFace (where logger.log is called
with imageUrl.slice(0, 80)) swallows errors; change the bare catch to capture
the error (e.g., catch (err)) and include the error or err.message in the
logger.log payload so the log records the exception details while preserving the
existing fail-safe behavior and returning false.

In `@src/content/resolveFaceGuide.ts`:
- Around line 38-51: The loop currently calls fetchImageFromUrl and detectFace
sequentially which adds latency; change it to first upload all images in
parallel (e.g., map images -> Promise of fetchImageFromUrl and await Promise.all
to get uploadedUrls in original order), then iterate uploadedUrls sequentially
and call detectFace(uploadedUrl) to preserve the "first face wins" behavior,
setting faceGuideUrl on the first detected face and pushing others into
additionalImageUrls; also handle per-upload failures (skip or throw) so
detectFace only runs on successful uploads. Reference: images array,
fetchImageFromUrl, detectFace, faceGuideUrl, and additionalImageUrls.

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/content/buildOverlayFilters.ts">

<violation number="1" location="src/content/buildOverlayFilters.ts:40">
P2: The comment says placeholders are named `[OVR0], [OVR1], …` but the code actually emits `[ovr_in_0], [ovr_in_1], …` (plus `[video_base]` as the chain entry point). Update the comment to list the real label names so callers know which strings to map to input-stream indices.</violation>
</file>

<file name="src/content/renderFinalVideo.ts">

<violation number="1" location="src/content/renderFinalVideo.ts:304">
P2: `overlay.filterChain` is computed by `buildOverlayFilters` but never used — the overlay filter logic is manually duplicated inline. This means `buildOverlayFilters` can diverge from the actual rendering without any visible breakage. Consider either using the helper's `filterChain` (fixing its placeholder labels) or removing the helper's filter logic and keeping only `inputs`.</violation>

<violation number="2" location="src/content/renderFinalVideo.ts:357">
P0: Missing `-map 0:a` for the audio stream in the overlay + lipsync path. Once `-map [out]` is used for explicit stream selection, ffmpeg drops all unmapped streams. The `!hasAudio` branch correctly maps audio, but this branch only sets `-c:a aac` without mapping — producing a silent video.</violation>
</file>

<file name="src/content/detectFace.ts">

<violation number="1" location="src/content/detectFace.ts:7">
P2: Substring matching on `"man"` causes false positives for non-person labels like `"ottoman"` or `"mannequin"`. Use word-boundary matching or normalize to exact/whole-word checks to avoid spurious face detections.</violation>
</file>

<file name="src/content/__tests__/buildOverlayFilters.test.ts">

<violation number="1" location="src/content/__tests__/buildOverlayFilters.test.ts:37">
P2: This test claims to verify non-overlapping positions but only asserts `toBeTruthy()`, which is already guaranteed by any non-empty input. Consider asserting that the two `overlay=` expressions contain distinct Y coordinates (e.g. by extracting positions from the filter chain), or remove the test to avoid giving false confidence about positioning logic.</violation>
</file>

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/content/__tests__/buildOverlayFilters.test.ts`:
- Around line 13-19: The tests for buildOverlayFilters currently only check for
the presence of "overlay=" and "scale=" which can pass despite incorrect
placement; update the assertions in the test cases (the one referencing
buildOverlayFilters at the top and the other around lines 33-37) to assert the
exact overlay coordinate clauses produced by buildOverlayFilters (e.g., assert
filterChain contains "overlay=<expectedX>:<expectedY>" or use a regex that
matches the precise x:y values) so the layout math is validated; keep using the
same function name buildOverlayFilters and assert the expected coordinates for
each scenario instead of the loose contains checks.

In `@src/content/loadTemplate.ts`:
- Around line 85-88: The current runtime type assertion for usesImageOverlay is
unsafe; replace it with Zod validation by defining a Zod schema (e.g.,
StyleGuideSchema) that specifies imagePrompt as optional string, usesFaceGuide
as boolean with default true, and usesImageOverlay as boolean with default
false, then safeParse/parse the styleGuide (the sg variable) inside the same
scope and extract imagePrompt, usesFaceGuide, and usesImageOverlay from the
validated result; update the code that currently sets
imagePrompt/usesFaceGuide/usesImageOverlay to use the parsed schema values so
string-"false" or other invalid values are rejected or coerced as intended.

In `@src/content/renderFinalVideo.ts`:
- Around line 340-345: The overlay stack overflows the frame when
overlayImagePaths is long; update the overlay loop in renderFinalVideo.ts to
compute a maximum number that fits the vertical space using FRAME_HEIGHT,
EDGE_PADDING, OVERLAY_SIZE and GAP (or alternatively compute scaled
OVERLAY_SIZE/GAP when count exceeds available space) and then iterate only over
Math.min(overlayImagePaths.length, maxOverlays) (or use the scaled sizes) so
computed y never becomes negative; adjust how outLabel/prevLabel/filterParts are
generated to reflect the reduced or scaled set so overlays render entirely
inside the frame.
- Around line 171-183: The downloaded overlay temp files in renderFinalVideo.ts
(overlayPaths array populated where overlay images are fetched) are never
deleted; update the cleanup in the function's finally block (the same place that
unlinks videoPath, audioPath, captionsPath, outputPath) to iterate overlayPaths
and unlink each file (safely ignoring missing files/errors) so per-run temp PNGs
are removed; reference the overlayPaths variable and the finally cleanup section
in renderFinalVideo to implement this.
- Around line 353-360: The video filter mapping "-map [out]" prevents ffmpeg
from auto-selecting audio, so in the renderFinalVideo logic when hasAudio is
true you must explicitly map the embedded audio (use the existing
audioInputIndex) before setting audio codec; update the branch that currently
only does args.push("-c:a", "aac") to also push args.push("-map",
`${audioInputIndex}:a:0`) (same mapping used in the else branch) so the audio
stream from input audioInputIndex is included when overlays/filtered video
output are used.

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/content/escapeDrawtext.ts">

<violation number="1" location="src/content/escapeDrawtext.ts:18">
P2: Percent escaping `%%%%` produces two `%` in rendered output instead of one. In ffmpeg drawtext, `%%` → literal `%`, so `%%%%` → `%%`. The replacement should be `%%` to get a single literal `%`.</violation>
</file>

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/content/buildFilterComplex.ts">

<violation number="1" location="src/content/buildFilterComplex.ts:48">
P1: `[out]` is not emitted when `captionFilters` is empty, but callers always `-map [out]`, which can break ffmpeg rendering.</violation>
</file>

<file name="src/content/downloadOverlayImages.ts">

<violation number="1" location="src/content/downloadOverlayImages.ts:23">
P1: Per-image download errors are not caught, so one thrown fetch/write failure aborts all remaining overlays instead of skipping failed images.</violation>
</file>

<file name="src/content/generateContentImage.ts">

<violation number="1" location="src/content/generateContentImage.ts:51">
P2: The new dedupe step does not remove duplicates within `additionalImageUrls`; it only excludes URLs already present in `imageUrls`.</violation>
</file>

<file name="src/content/renderFinalVideo.ts">

<violation number="1" location="src/content/renderFinalVideo.ts:222">
P1: Custom agent: **Flag AI Slop and Fabricated Changes**

`overlayPaths` is referenced in `finally` out of scope, causing an unresolved identifier build failure.</violation>
</file>